Issue with short syntax and Phalcon\Mvc\Router\Group

Question

Issue with short syntax and Phalcon\Mvc\Router\Group

Tim Robertson Sep '13

Created Sep '13	Last Reply Sep '13	Replies 2	Views 940	Votes 1

Tim Robertson 2.4k

Sep '13

I'm trying to use the short syntax when adding routes inside a router group. The router matches the route properly but the controller name and action name come back as null.

Do router groups not support the same short syntax as the router?

class Routes extends Phalcon\Mvc\Router\Group
{
    public function initialize()
    {
        $this->add('/posts', 'Post::index');
    }
}

$router->mount(new Routes);
$router->handle();

var_dump( $router->getControllerName() );

1

Phalcon · Answer 1 · 2013-09-21T17:27:42-07:00

This example is giving me: string(4) "post"

class Routes extends Phalcon\Mvc\Router\Group
{
  public function initialize()
  {
    $this->add('/posts', 'Post::index');
  }
}

$router = new Phalcon\Mvc\Router(false);
$router->mount(new Routes);
$router->handle('/posts');

var_dump( $router->getControllerName() );

Tim Robertson · Answer 2 · 2013-09-21T17:59:42-07:00

Sorry my bad. I've narrowed down whats triggering the problem. When you set the namespace using setPaths() then the short syntax no longer works.

class Routes extends Phalcon\Mvc\Router\Group
{
    public function initialize()
    {
        $this->setPaths([
            'namespace' => 'Ds\Backend\Controllers',
        ]);
        $this->add('/posts', 'Post::index');
    }
}

$router = new Phalcon\Mvc\Router(false);
$router->mount(new Routes);
$router->handle('/posts');

var_dump( $router->getControllerName() );

Phalcon · Answer 3 · 2013-09-23T09:25:12-07:00

This works:

<?php

class Routes extends Phalcon\Mvc\Router\Group
{
  public function initialize()
  {    
    $this->add('/posts', 'Db\Backend\Controllers\Post::index');
  }
}

$router = new Phalcon\Mvc\Router(false);
$router->mount(new Routes);
$router->handle('/posts');

var_dump( $router->getNamespaceName() );
var_dump( $router->getControllerName() );

Tim Robertson · Answer 4 · 2013-09-23T22:25:23-07:00

Rather than having the short syntax assume the global namespace wouldn't it make more sense if it operated as follows:

preg_match('/^(?<namespace>.*\\\\?)(?<controller>[^\\\\]+)::(?<action>.+)$/U', 'Db\Backend\Controllers\Post::index', $matches);
print_r($matches);

preg_match('/^(?<namespace>.*\\\\?)(?<controller>[^\\\\]+)::(?<action>.+)$/U', 'Post::index', $matches);
print_r($matches);

/*

Array
(
    [0] => Db\Backend\Controllers\Post::index
    [namespace] => Db\Backend\Controllers\
    [1] => Db\Backend\Controllers\
    [controller] => Post
    [2] => Post
    [action] => index
    [3] => index
)

Array
(
    [0] => Post::index
    [namespace] => 
    [1] => 
    [controller] => Post
    [2] => Post
    [action] => index
    [3] => index
)

*/

The set the namespace only if found in the short syntax. This way it would respect the default namespace for the group if it has been set.